-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[WebProfilerBundle] Make the IP address in the profiler header clickable #19815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebProfilerBundle] Make the IP address in the profiler header clickable #19815
Conversation
jameshalsall
commented
Sep 1, 2016
•
edited
Loading
edited
Q | A |
---|---|
Branch? | master |
Bug fix? | no |
New feature? | yes |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
License | MIT |
I know that we already had some discussion about this topic. ping @javiereguiluz |
What is the actual use case for this change? |
This is to make it easier to jump to results for the current IP, which brings it inline with the behaviour of clicking on the URL. |
Let's answer two questions: How common is it that you have profiles with different IP addresses which would justify a need for this feature? And would it be confusing for all other users that the IP address is clickable? |
|
👍 I like this proposal because it changes nothing for most users and it improves the productivity of those using this. @jameshalsall I'd like to have a minor change before merge: let's make the new link look like the previous text. In line 494 of profiler.css.twig, please update the selector to this: #summary dl.metadata,
#summary dl.metadata a { /* <-- add this line */
margin: 5px 0 0;
color: rgba(255, 255, 255, 0.75);
} |
…ble to view requests by IP
bd45598
to
52606a1
Compare
This has now been updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thank you @jameshalsall. |
…r header clickable (jameshalsall) This PR was merged into the 3.3-dev branch. Discussion ---------- [WebProfilerBundle] Make the IP address in the profiler header clickable | Q | A | | --- | --- | | Branch? | master | | Bug fix? | no | | New feature? | yes | | BC breaks? | no | | Deprecations? | no | | Tests pass? | yes | | License | MIT | Commits ------- 52606a1 [WebProfilerBundle] Make the IP address in the profiler header clickable to view requests by IP
…profiler header clickable (jameshalsall) This PR was merged into the 3.3-dev branch. Discussion ---------- [WebProfilerBundle] Make the IP address in the profiler header clickable | Q | A | | --- | --- | | Branch? | master | | Bug fix? | no | | New feature? | yes | | BC breaks? | no | | Deprecations? | no | | Tests pass? | yes | | License | MIT | Commits ------- 52606a1 [WebProfilerBundle] Make the IP address in the profiler header clickable to view requests by IP