Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WebProfilerBundle] Make the IP address in the profiler header clickable #19815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2017

Conversation

jameshalsall
Copy link
Contributor

@jameshalsall jameshalsall commented Sep 1, 2016

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

@fabpot
Copy link
Member

fabpot commented Sep 6, 2016

I know that we already had some discussion about this topic. ping @javiereguiluz

@xabbuh
Copy link
Member

xabbuh commented Oct 13, 2016

What is the actual use case for this change?

@jameshalsall
Copy link
Contributor Author

This is to make it easier to jump to results for the current IP, which brings it inline with the behaviour of clicking on the URL.

@xabbuh
Copy link
Member

xabbuh commented Oct 13, 2016

Let's answer two questions: How common is it that you have profiles with different IP addresses which would justify a need for this feature? And would it be confusing for all other users that the IP address is clickable?

@jameshalsall
Copy link
Contributor Author

  1. Quite, if you're viewing the debug profiler in a non-local environment which a lot of people seem to do
  2. I'm not sure it would be confusing given that it's styled exactly the same as the URL in the same part of the profiler.

@javiereguiluz
Copy link
Member

👍 I like this proposal because it changes nothing for most users and it improves the productivity of those using this.

@jameshalsall I'd like to have a minor change before merge: let's make the new link look like the previous text. In line 494 of profiler.css.twig, please update the selector to this:

#summary dl.metadata,
#summary dl.metadata a {    /*  <-- add this line  */
    margin: 5px 0 0;
    color: rgba(255, 255, 255, 0.75);
}

@jameshalsall jameshalsall force-pushed the clickable-ip-profiler-layout branch from bd45598 to 52606a1 Compare November 9, 2016 21:52
@jameshalsall
Copy link
Contributor Author

This has now been updated.

@fabpot fabpot modified the milestones: 3.3, 3.2 Nov 16, 2016
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fabpot
Copy link
Member

fabpot commented Feb 14, 2017

Thank you @jameshalsall.

@fabpot fabpot merged commit 52606a1 into symfony:master Feb 14, 2017
fabpot added a commit that referenced this pull request Feb 14, 2017
…r header clickable (jameshalsall)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[WebProfilerBundle] Make the IP address in the profiler header clickable

| Q | A |
| --- | --- |
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| License | MIT |

Commits
-------

52606a1 [WebProfilerBundle] Make the IP address in the profiler header clickable to view requests by IP
@nicolas-grekas nicolas-grekas modified the milestones: 3.x, 3.3 Mar 24, 2017
@fabpot fabpot mentioned this pull request May 1, 2017
ostrolucky pushed a commit to ostrolucky/symfony that referenced this pull request Mar 25, 2018
…profiler header clickable (jameshalsall)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[WebProfilerBundle] Make the IP address in the profiler header clickable

| Q | A |
| --- | --- |
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| License | MIT |

Commits
-------

52606a1 [WebProfilerBundle] Make the IP address in the profiler header clickable to view requests by IP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants