[Workflow] Make PropertyAccess required dependency #19849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Status: Reviewed |
|
It's necessary only for default Marking Store implementations. If you use custom implementations, you may not want this package. A |
|
@dunglas Hypothetically, yes, however - as a newcomer who wants to use the component, this is either not the best first impression - you install the |
|
I've no strong opinion about that. It was just some thought. We have basically 2 possibilities:
|
|
Thank you @OndraM. |
fabpot
added a commit
that referenced
this pull request
Sep 5, 2016
This PR was merged into the 3.2-dev branch. Discussion ---------- [Workflow] Make PropertyAccess required dependency | Q | A | ------------- | --- | Branch? | master (3.2 is not yet released) | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | N/A | Fixed tickets | N/A | License | MIT | Doc PR | N/A Hi, when using Workflow as a standalone component (and instantiating new `Workflow()` instance), I'm getting errors like: ``` PHP Fatal error: Class 'Symfony\Component\PropertyAccess\PropertyAccess' not found in .../workflow-example/vendor/symfony/workflow/MarkingStore/PropertyAccessorMarkingStore.php on line 37 ``` The reason is the PropertyAccessorMarkingStore (and the ScalarMarkingStore as well) [uses](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Workflow/MarkingStore/PropertyAccessorMarkingStore.php#L14) PropertyAccess class. So it is basically not possible to use the component without the symfony/property-access. Is this correct @lyrixx? Commits ------- 5957412 [Workflow] Make PropertyAccess required dependency
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, when using Workflow as a standalone component (and instantiating new
Workflow()instance), I'm getting errors like:The reason is the PropertyAccessorMarkingStore (and the ScalarMarkingStore as well) uses PropertyAccess class. So it is basically not possible to use the component without the symfony/property-access.
Is this correct @lyrixx?