[Yaml] Add bin/lint for using the LintCommand #19916
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I'm slightly 👎 on adding a script here. This is a component, so it gives you building blocks that you can assemble the way you want. What others think? ping @symfony/deciders |
|
I think you're right, adding such example to the documentation should be enough for the use case. |
|
@chalasr Can you submit a doc PR then? That sounds indeed very useful to have this in the docs. |
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 28, 2016
…luz) This PR was submitted for the master branch but it was merged into the 3.2 branch instead (closes #6963). Discussion ---------- [Yaml] Add lint:yaml command usage This documents symfony/symfony#19139 (merged on 3.2) and closes symfony/symfony#19916. Commits ------- ed4cb40 Remove an unneeded code directive 44b4ad0 Use `terminal` instead of `bash` for console code 78075c1 Yaml] Add lint:yaml command usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #19139 we moved the
lint:yamlcommand from the FrameworkBundle to the Yaml component.The usage did not change in the framework, the old command became a child of the Yaml one.
But now, using this command in the standalone Yaml requires to create an application. Here I propose to provide the application as an executable, so that the command is really usable directly when installing the yaml+console components as dependencies.
I may be wrong when I think it's worth it but to me, moving the command to the yaml component doesn't fully make sense if it cannot be used directly outside of the full stack framework.