[Dependency Injection] Add autowiring types for aliases#19970
Closed
hason wants to merge 1 commit intosymfony:masterfrom
Closed
[Dependency Injection] Add autowiring types for aliases#19970hason wants to merge 1 commit intosymfony:masterfrom
hason wants to merge 1 commit intosymfony:masterfrom
Conversation
chalasr
reviewed
Sep 19, 2016
| * Adds a type that will default to this definition. | ||
| * | ||
| * @param string $type | ||
| * |
Member
There was a problem hiding this comment.
- @return Definition
+ @return AliasSame below
Contributor
|
Is it a good idea to use aliases for setting the autowiring type ? |
Contributor
Author
Member
|
@hason the idea is to say |
Contributor
Author
|
Oh no! This doesn't work. The autowiring types are lost after each change of alias definition. |
Member
|
services:
foo_type:
public: false
parent: foo
autowiring_types: [ FooInterface ] |
fabpot
added a commit
that referenced
this pull request
Feb 1, 2017
…icolas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] Deprecate autowiring-types in favor of aliases | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #21351, #19970, ~~#18040~~, ~~#17783~~ | License | MIT | Doc PR | symfony/symfony-docs#7445 https://github.com/symfony/symfony/pull/21494/files?w=1 This PR deprecates autowiring-types and replaces them by plain aliases. ping @dunglas @weaverryan Eg instead of ```xml <service id="annotations.reader" class="Doctrine\Common\Annotations\AnnotationReader" public="false"> <autowiring-type>Doctrine\Common\Annotations\Reader</autowiring-type> </service> ``` just do: ```xml <service id="annotations.reader" class="Doctrine\Common\Annotations\AnnotationReader" public="false" /> <service id="Doctrine\Common\Annotations\Reader" alias="annotations.reader" public="false" /> ``` Commits ------- b11d391 [DI] Deprecate autowiring-types in favor of aliases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.