[2.7][Console] consistent application help with 3.2#20090
Closed
ro0NL wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
ping @lyrixx :) edit: #16906 (comment) what happened? |
Member
|
@ro0NL I dont understand what you expect from me. |
Contributor
Author
|
Can you conform this should be applied on 2.7? |
Member
|
No I can't. I think it could be considered as a BC break. But I'm not sure. |
Contributor
Author
|
@fabpot do you qualify this a bugfix? Im not sure the difference is intended.. Otherwise lets close it :) As (to me) 3.2 has the correct behavior already (which was also a BC break then?) |
Member
|
I would prefer to close it as this is technically a BC break, and anyway, that does not fix a problem, so there is no need to "fix" it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix from #16906 that should have targeted 2.7 as well imo.
2.7 / before
2.7 / after
master / current
Also shows the problem with
ListCommand::getNativeDefinitionas now the options are incorrect. Fixed that in #20054.. so these should probably both go on 2.7.Hopes this makes it clear.