[Templating] asset packages #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set versions can be set more granularly
|
This is great, but if you don't specify the version I hope it takes the last-modified date or something as a version? If it doesn't yet, then it would be a great addition, maybe with an explicit version: auto or something.. |
|
This doesn't touch the filesystem, it only uses the configured value. Using the filesystem isn't reliable anyway because mtimes may not be in sync across multiple web nodes. |
|
Why not use a hash of the file contents + formula? Something that is reproducible for the same asset content. Not sure why one should have to manually maintain the versions at all. |
|
Because that requires touching the filesystem to answer my own question, nevermind ... |
SofHad
pushed a commit
to SofHad/symfony
that referenced
this pull request
Oct 12, 2015
…ion (yceruto, javiereguiluz) This PR was merged into the master branch. Discussion ---------- Use a modal window to confirm the blog post deletion This pull request finished symfony#202 by making some tweaks to the design of the delete dialog. **Before** We used the classic Yes/No dialog mostly used in Windows systems:  **After** I propose to use the Delete/Cancel dialog used in Apple systems, because it's more user friendly:  I've just tweaked this dialog contents. The rest of the pull request is the result of the great work made by @yceruto. Commits ------- 620162b Updated the styles for the latest changes 36e61c5 Use a modal window to confirm the blog post deletion 0a2e717 disable submit button on submit. fecb034 rename js file e07792d fixing file documentation db88d34 fixing file documentation c0aaf79 confirmation message using bootstrap modal a41db16 using short name and statements 0a8299f avoids a DOM query for 'body' and avoids the need to wait for DOM ready db98a4e check the show_confirmation_message value 86d4f1c using event delegation d731ee8 removed multi-purpose variables 775ddba removing old code 167e3a1 confirmation message now listen from submit event of the form fd91b05 Removed return statement and improving the code. 40e771d Fixing translation position f6aa107 feature symfony#191 Add confirmation message before to delete a post
jderusse
pushed a commit
to jderusse/symfony
that referenced
this pull request
Mar 30, 2020
This vulnerability exists in the underlying Zend 1.x library. The upstream Zend library has hit EOL, however Magento maintains a fork of the library with security fixes as they migrate to Zend 2.x (in Magento 2) This vulnerability exists in code in both the CE and EE version Fixes symfony#202
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've introduced the concept of asset packages in this patch.
An asset package has two properties, both of which are optional:
Using asset packages you can now increment asset versions more specifically. For instance, if you make a change to a CSS stylesheet, there is no need to change the version number on all of your images.
A YAML configuration looks like this:
In XML:
In your template, you pass the package name to the helper:
Or in PHP:
The following methods were removed from
AssetsHelperas a part of this patch:setVersion()getBaseUrls()setBaseUrls()