Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Workflow] Set the marking then announce enabled transition #20464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2016

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Nov 9, 2016

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

It allows to auto-apply some transition from a listener. If we don't do that, the marking is not updated in the listener yet, so the transition is not really enabled.

The feature was asked on twitter
And It has been implemented (userland) here

It allows to auto-apply some transition from a listener.

The feature was asked here: https://twitter.com/gaetanbuellet/status/796387741420441600
And It has been implemented in userland here:
https://github.com/lyrixx/SFLive-Paris2016-Workflow/tree/auto-apply
@nicolas-grekas
Copy link
Member

👍

@javiereguiluz javiereguiluz added this to the 3.2 milestone Nov 10, 2016
@lyrixx lyrixx merged commit 51dad72 into symfony:master Nov 10, 2016
lyrixx added a commit that referenced this pull request Nov 10, 2016
…ion (lyrixx)

This PR was merged into the 3.2-dev branch.

Discussion
----------

[Workflow] Set the marking then announce enabled transition

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

It allows to auto-apply some transition from a listener. If we don't do that, the marking is not updated in the listener yet, so the transition is not really enabled.

The feature was asked on [twitter](https://twitter.com/gaetanbuellet/status/796387741420441600)
And It has been implemented (userland) [here](lyrixx/SFLive-Paris2016-Workflow@9fda92a)

Commits
-------

51dad72 [Workflow] Set the marking then announce enabled transition
@lyrixx lyrixx deleted the workflow-announce branch November 10, 2016 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants