[Workflow] Fixed some tests and cs #20507
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
reviewed
Nov 13, 2016
| { | ||
| /** | ||
| * @expectedException \Symfony\Component\Workflow\Exception\InvalidDefinitionException | ||
| * @expectedExceptionMessage The marking store of workflow "foo" can not store many places. | ||
| */ | ||
| public function testSinglePlaceWorkflowValidatorAndComplexWorkflow() | ||
| { | ||
| $definition = $this->createComplexWorkflow(); | ||
| $definition = WorkflowTest::createComplexWorkflow(); |
There was a problem hiding this comment.
Maybe just create a minimal workflow here. I thought of this as well for #20492 but i forgot :))
lyrixx
requested changes
Nov 14, 2016
| { | ||
| /** | ||
| * @expectedException \Symfony\Component\Workflow\Exception\InvalidDefinitionException | ||
| * @expectedExceptionMessage The marking store of workflow "foo" can not store many places. | ||
| */ | ||
| public function testSinglePlaceWorkflowValidatorAndComplexWorkflow() | ||
| { | ||
| $definition = $this->createComplexWorkflow(); | ||
| $definition = WorkflowTest::createComplexWorkflow(); |
|
@HeahDude Could you take time to finish this one, I want to merge it asap |
|
Closing in favor of #20548 |
lyrixx
added a commit
that referenced
this pull request
Nov 17, 2016
This PR was merged into the 3.2-dev branch. Discussion ---------- [Workflow] Refactored test suite | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20507 | License | MIT | Doc PR | - Commits ------- cef6f31 [Workflow] Refactored tests suite 3ee876b [Workflow] Fixed validator tests and used static function to create workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests are run twice because the
SinglePlaceWorkflowValidatorTestextends theWorkflowTest, let's use a static function instead.