[FrameworkBundle] Allowed symlinks when searching for translation, searialization and validation files #20547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we want to allow symlinks here, we should do the same for the validation files. What do you think? |
|
I agree. What about serialization files? |
|
I added the followLinks on both serialization and validation files |
|
@xabbuh Is it OK for you? Note that I don't understand why the travis build is in error for PHP5.3. |
|
Looks like a new behavior, thus new feature to me. Am I wrong? |
|
Agreed, to treat this as a new features. Besides that 👍 from me. |
|
If you consider this as a new feature, do I need to rebase my branch on top of master or 3.2(as it's not released yet)? |
|
New features should now go to |
|
OK for me I changed the destination branch. |
|
👍 |
|
Thank you @tifabien. |
fabpot
added a commit
that referenced
this pull request
Jan 6, 2017
…translation, searialization and validation files (tifabien) This PR was squashed before being merged into the 3.3-dev branch (closes #20547). Discussion ---------- [FrameworkBundle] Allowed symlinks when searching for translation, searialization and validation files | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - When we have a symlink folder in app/Resources/translations, files inside this symlink are not handled. Commits ------- 4874e43 [FrameworkBundle] Allowed symlinks when searching for translation, searialization and validation files
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have a symlink folder in app/Resources/translations, files inside this symlink are not handled.