[FrameworkBundle] Fix notice in Translator #206
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the translator class in FrameworkBundle uses it. I feel somewhat anxious with all these private things.
|
indeed, 75b29ff introduces a notice: |
|
see PR 207 |
SofHad
pushed a commit
to SofHad/symfony
that referenced
this pull request
Oct 12, 2015
…elease (bocharsky-bw) This PR was merged into the master branch. Discussion ---------- Update dependencies according to Symfony v2.7.5 release Commits ------- f1aa3cd Update dependencies according to Symfony v2.7.5 release
jderusse
pushed a commit
to jderusse/symfony
that referenced
this pull request
Mar 30, 2020
Add PHP CodeSniffer advisory 2017-03-01
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Translator.locale property protected, because the translator class in FrameworkBundle uses it.
I feel somewhat anxious with all these private things. So many doors closed.