Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[VarDumper] word-break: break-all for long string dumps #20647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2016
Merged

[VarDumper] word-break: break-all for long string dumps #20647

merged 1 commit into from
Dec 17, 2016

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Nov 26, 2016 •
edited
Loading

Q A
Branch? "master"
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT
Doc PR reference to the documentation PR, if any

Before

image

After

image

@ogizanagi
Copy link
Contributor

ogizanagi commented Nov 26, 2016 •
edited
Loading

Could you ensure it won't bring any regression in the profiler bar with popular css frameworks' rules like with Twitter Bootstrap? I'm mentioning this because of this fix I've provided some time ago and this: #16183 (comment).

Otherwise, we may have to set this only for the profiler pages or find a proper solution for both.

@ro0NL
Copy link
Contributor Author

ro0NL commented Nov 26, 2016

Hm, current master applies a 200px width already; https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.css.twig#L378

Before

image

After

image

Chrome 54.0

@fabpot
Copy link
Member

fabpot commented Dec 13, 2016

👍

@xabbuh
Copy link
Member

xabbuh commented Dec 17, 2016

👍

@fabpot
Copy link
Member

fabpot commented Dec 17, 2016

Thank you @ro0NL.

@fabpot fabpot merged commit bd4c430 into symfony:master Dec 17, 2016
fabpot added a commit that referenced this pull request Dec 17, 2016
@fabpot
minor #20647 [VarDumper] word-break: break-all for long string dumps …
3eab98d 
…(ro0NL)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[VarDumper] word-break: break-all for long string dumps

| Q             | A
| ------------- | ---
| Branch?       | "master"
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | comma-separated list of tickets fixed by the PR, if any
| License       | MIT
| Doc PR        | reference to the documentation PR, if any

Before

![image](https://cloud.githubusercontent.com/assets/1047696/20641702/50000ee8-b3fe-11e6-8390-a6ba3dae5c56.png)

After

![image](https://cloud.githubusercontent.com/assets/1047696/20641724/76671d56-b3fe-11e6-8fa0-4c00801b3069.png)

Commits
-------

bd4c430 [VarDumper] Break all words in long string dump
@ro0NL ro0NL deleted the var-dumper/break-words branch December 17, 2016 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review VarDumper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ro0NL @ogizanagi @fabpot @xabbuh @carsonbot