[2.7][HttpKernel] Regression test for missing controller arguments #20755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Thank you @iltar. |
fabpot
added a commit
that referenced
this pull request
Dec 5, 2016
…rguments (iltar) This PR was merged into the 2.7 branch. Discussion ---------- [2.7][HttpKernel] Regression test for missing controller arguments | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20746 | License | MIT | Doc PR | ~ This fix should ensure that when an action has a mandatory parameter without a type, it will throw the exception instead of inserting null. This test was missing when adding nullable support in 2.7 and up (probably has to be added to 3.1 as well). Commits ------- d1a7164 Regression test for missing controller arguments
fabpot
added a commit
that referenced
this pull request
Dec 5, 2016
…rguments (iltar) This PR was merged into the 3.1 branch. Discussion ---------- [3.1][HttpKernel] Regression test for missing controller arguments | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20746 | License | MIT | Doc PR | ~ Same fix as #20755 but for 3.1 and up as the new feature was hit by the same bug. ping @fabpot Commits ------- 9e588b8 Regression test for missing controller arguments (3.1)
This was referenced Dec 13, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix should ensure that when an action has a mandatory parameter without a type, it will throw the exception instead of inserting null.
This test was missing when adding nullable support in 2.7 and up (probably has to be added to 3.1 as well).