[Workflow] Added an entered event #20787
Conversation
Padam87
commented
Dec 6, 2016
•
| Q | A |
|---|---|
| Branch? | 3.2 |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #20774 (partially) ; #21433 |
| License | MIT |
| Doc PR | - |
|
Hello @Padam87 1/ there is already the |
|
Hi, I have expained in the issue. The |
|
Thanks @Padam87 for your time. But sadly I'm still 👎 about this event. We already have many events. More over if you really want to to have your flush outside the controller, you can put it in the marking store. As well it makes more sense since the marking store, is all about the "store", and so the DB. I need to close this PR as "won't fix" because of the -1 votes from the Symfony Core Team members. The Workflow component is very recent, so we are very cautious about adding new features to it. In any case, if more users complain about this very same thing, we'll reconsider your proposal for Symfony 3.3. Thanks! |
|
@Padam87 Could you rebase the PR? Thanks. |
| } | ||
|
|
||
| foreach ($transition->getTos() as $place) { | ||
| $marking->mark($place); |
There was a problem hiding this comment.
The logic is wrong here, the marking is already set in the enter method
There was a problem hiding this comment.
Oops, totally missed this, thx
| @@ -238,6 +240,24 @@ private function enter($subject, Transition $transition, Marking $marking) | |||
| } | |||
| } | |||
|
|
|||
| private function entered($subject, Transition $transition, Marking $marking) | |||
| { | |||
| if (null !== $this->dispatcher) { | |||
There was a problem hiding this comment.
if (null == $this->dispatcher) { return ; }
54d66c9 to
8adfb58
Compare
8adfb58 to
7c7725c
Compare
|
👍 |
|
Thank you @Padam87. |
|
@lyrixx Can you add a note in the component CHANGELOG? |
|
Yes, I will make a PR. |
This PR was merged into the 3.3 branch. Discussion ---------- Adding missing workflow.entered events see symfony/symfony#20787 Commits ------- 1391473 Adding missing workflow.entered events