[Validator] phpize default option values #20961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Dec 16, 2016
| @@ -84,7 +84,7 @@ protected function parseConstraints(\SimpleXMLElement $nodes) | |||
| $options = array(); | |||
| } | |||
| } elseif (strlen((string) $node) > 0) { | |||
| $options = trim($node); | |||
| $options = XmlUtils::phpize($node); | |||
There was a problem hiding this comment.
removing the trimming is a BC break
This makes the behavior for default constraints inline with the behavior when the option is given explicitly.
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Dec 17, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [Validator] phpize default option values | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13740 | License | MIT | Doc PR | This makes the behavior for default constraints inline with the behavior when the option is given explicitly. Commits ------- d65679b [Validator] phpize default option values
This was referenced Jan 12, 2017
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the behavior for default constraints inline with the behavior
when the option is given explicitly.