fix for ignoring abstract definition #210
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, could you add a unit test for this behavior? |
|
@Kertz: Are you working on adding some unit tests? |
|
Yes I will add some unit tests by tomorrow |
|
Added some tests |
|
merged. Just a side note, it's better if you can create a branch whenever you make a pull request (http://symfony.com/doc/2.0/contributing/code/patches.html). |
|
@fabpot, sorry will follow that from next time. |
SofHad
pushed a commit
to SofHad/symfony
that referenced
this pull request
Oct 12, 2015
… (voronkovich) This PR was merged into the master branch. Discussion ---------- Remove unnecessary quotes from services definitions Commits ------- 3c98a14 Remove unnecessary quotes from services definitions
jderusse
pushed a commit
to jderusse/symfony
that referenced
this pull request
Mar 30, 2020
adding SimpleSAMLphp 201703-01 and 201703-02
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to stop exception from being thrown when the parent is not defined for an abstract definition.