[SecurityBundle] Made collection of user provider unique when injecting them to the RemberMeService #21032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Dec 23, 2016
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
…ng them to the RemberMeService
1460125 to
8227593
Compare
|
Fabbot is wrong. |
|
When can the collection be non-unique? Can we add a test covering this? |
If you have many authentication provider in a firewall that use the same user provider
yes, I guess ;) |
|
I wanted to add tests, but for now, there are no tests on this class. IMHO, we can merge this one as this. |
xabbuh
approved these changes
Dec 30, 2016
|
Thank you @lyrixx. |
fabpot
added a commit
that referenced
this pull request
Dec 31, 2016
…hen injecting them to the RemberMeService (lyrixx) This PR was merged into the 2.7 branch. Discussion ---------- [SecurityBundle] Made collection of user provider unique when injecting them to the RemberMeService | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 8227593 [SecurityBundle] Made collection of user provider unique when injecting them to the RemberMeService
This was referenced Jan 12, 2017
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.