fixed @return when returning this or static #21059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
reviewed
Dec 27, 2016
| @@ -145,7 +145,7 @@ public function getStyle() | |||
| * @param int $columnIndex Column index | |||
| * @param TableStyle|string $name The style name or a TableStyle instance | |||
| * | |||
| * @return Table | |||
| * @return self | |||
| @@ -547,7 +547,7 @@ public function getFile() | |||
| * | |||
| * @param bool $shared Whether the service must be shared or not | |||
| * | |||
| * @return Definition The current instance | |||
| * @return self | |||
There was a problem hiding this comment.
$this (same for each changes in this class)
fabpot
added a commit
that referenced
this pull request
Dec 29, 2016
This PR was merged into the 2.8 branch. Discussion ---------- fixed @return when returning this or static | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Follow-up of #21054 for the 2.8 branch. Commits ------- 7808b67 fixed @return when returning this or static
fabpot
added a commit
that referenced
this pull request
Dec 30, 2016
…agi) This PR was merged into the 2.8 branch. Discussion ---------- Fixed @return when returning this or static #bis | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A For some reasons these weren't fixed before #21059 was merged despite the review comments 😆 Commits ------- 20d8c74 Fixed @return when returning this or static #bis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #21054 for the 2.8 branch.