Polish translation improvement in Validator component #21091
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
szepczynski
commented
Dec 29, 2016
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | no |
| License | MIT |
jakzal
reviewed
Dec 29, 2016
| </trans-unit> | ||
| <trans-unit id="10"> | ||
| <source>This field is missing.</source> | ||
| <target>To pole jest chybianie.</target> | ||
| <target>To pole jest brakujące.</target> |
There was a problem hiding this comment.
Perhaps "Tego pola brakuje." would read better?
|
👍 |
daryush
reviewed
Dec 29, 2016
| @@ -36,11 +36,11 @@ | |||
| </trans-unit> | |||
| <trans-unit id="9"> | |||
| <source>This field was not expected.</source> | |||
| <target>To pole nie spodziewano.</target> | |||
| <target>Tego pola się nie spodziewano.</target> | |||
There was a problem hiding this comment.
IMHO "To pole nie było spodziewane." would be more consistent form with other translations.
There was a problem hiding this comment.
@daryush "To pole nie było spodziewane." doesn't sound like polish
|
Thank you @szepczynski. |
fabpot
added a commit
that referenced
this pull request
Dec 29, 2016
…zepczynski) This PR was squashed before being merged into the 2.7 branch (closes #21091). Discussion ---------- Polish translation improvement in Validator component | Q | A | ------------- | --- | Branch? | 2.7 <!--see comment below--> | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | no | License | MIT <!-- - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. - Please fill in this template according to the PR you're about to submit. - Replace this comment by a description of what your PR is solving. --> Commits ------- 7a603df Polish translation improvement in Validator component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.