[FrameworkBundle] Display original definition for aliases in debug:container #21129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofidry
approved these changes
Jan 2, 2017
| $serviceId = $options['id']; | ||
|
|
||
| do { | ||
| $serviceId = (string) $builder->getAlias($serviceId); |
There was a problem hiding this comment.
would it be possible to write data for each alias as well? So that if you have alias1 -> alias2 -> service you see something along the lines of:
- alias1 is an alias for alias2
- alias2 is an alias for service
- <service description>
There was a problem hiding this comment.
It would be indeed better but it doesn't look possible, AFAIK there's no way to handle chained aliases, it direct gives the original id.
Given alias1 is an alias of original and, alias2 is an alias of alias1, running debug:container alias2 currently gives
This service is an alias for the service "original",
and not
This service is an alias for the service "alias1"
:/
There was a problem hiding this comment.
Hm ok, but then why is this looping necessary then?
There was a problem hiding this comment.
I just realized this, it is useless :)
985af21 to
c919eab
Compare
dunglas
requested changes
Jan 3, 2017
| @@ -141,7 +141,7 @@ protected function write($content, $decorated = false) | |||
| * @param Definition|Alias|object $service | |||
| * @param array $options | |||
There was a problem hiding this comment.
The PHPDoc must be updated (new arg)
| @@ -168,7 +168,7 @@ protected function write($content, $decorated = false) | |||
| * @param Alias $alias | |||
| * @param array $options | |||
| @@ -266,12 +275,15 @@ private function getContainerTagsDocument(ContainerBuilder $builder, $showPrivat | |||
| * | |||
6d89444 to
8d78b8a
Compare
|
@dunglas Phpdoc fixed and test added. Thank you for the review. |
285bee8 to
86b7ec2
Compare
|
Tests are green |
86b7ec2 to
cd4b15e
Compare
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Jan 4, 2017
…ses in debug:container (chalasr) This PR was merged into the 3.3-dev branch. Discussion ---------- [FrameworkBundle] Display original definition for aliases in debug:container | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20954 | License | MIT | Doc PR | n/a Before  After  <details> <summary>XML output</summary> Before  After  </details> <details> <summary>JSON output</summary> Before  After  </details> <details> <summary>Markdown output</summary> Before  After  </details> Commits ------- cd4b15e [FrameworkBundle] Display original definition for aliases in debug:container
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
XML output
Before
After
JSON output
Before
After
Markdown output
Before
After
