[Validator] Add object handling of invalid constraints in Composite #21208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @SenseException. |
fabpot
added a commit
that referenced
this pull request
Mar 22, 2017
…Composite (SenseException) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #21208). Discussion ---------- [Validator] Add object handling of invalid constraints in Composite | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21206 | License | MIT | Doc PR | n/a This PR fixes a minor bug described in #21206. The constraint `Symfony\Component\Validator\Constraints\Composite` doesn't check in it's exception handling if the wrongly created instance of a nested constraint is an object, which is the expected type for a constraint. Commits ------- 4bd2c22 [Validator] Add object handling of invalid constraints in Composite
This was referenced Apr 4, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor bug described in #21206. The constraint
Symfony\Component\Validator\Constraints\Compositedoesn't check in it's exception handling if the wrongly created instance of a nested constraint is an object, which is the expected type for a constraint.