[VarDumper] Add search keyboard shortcuts #21238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Tried it out, 👍 Status: reviewed |
7 tasks
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Jan 15, 2017
This PR was merged into the 3.3-dev branch. Discussion ---------- [VarDumper] Add search keyboard shortcuts | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21174 | License | MIT | Doc PR | Worth to mention? So, this PR simply adds the following shortcuts to navigate between matches, based on main browsers conventions: - <kbd>CTRL/CMD</kbd> + (<kbd>shift</kbd>* +) <kbd>G</kbd> - (<kbd>shift</kbd>* +) <kbd>ENTER</kbd> - (<kbd>shift</kbd>* +) <kbd>F3</kbd> _* <kbd>shift</kbd> allows to go backwards_ At first, I wanted to add a help box somewhere, but: - I don't know where to place it. As the var dumper is now used everywhere in the profiler, it should not be importune and should work in narrowed places. - We use those shortcuts in order to replicate the main softwares/browsers behavior. So we may not need it at all. This PR also fixes a minor issue where pressing a key not changing the input would have restarted the search query. Commits ------- 58fe431 [VarDumper] Add search keyboard shortcuts
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this PR simply adds the following shortcuts to navigate between matches, based on main browsers conventions:
* shift allows to go backwards
At first, I wanted to add a help box somewhere, but:
This PR also fixes a minor issue where pressing a key not changing the input would have restarted the search query.