[Debug] Fix fatal error when changing ErrorHandler loggers if an exception is buffered #21311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption is buffered
|
👍 |
|
Good catch, thanks @skalpa. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 16, 2017
… if an exception is buffered (skalpa) This PR was merged into the 3.2 branch. Discussion ---------- [Debug] Fix fatal error when changing ErrorHandler loggers if an exception is buffered | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21304 | License | MIT | Doc PR | - Prevents a fatal error when setting a new logger if the bootstrapping logger buffered an exception that does not extend `ErrorException`. @nicolas-grekas The faulty behaviour was added by 8f24549, so this PR is against 3.2 and not 2.8. Commits ------- a6527f8 [Debug] Fix fatal error when changing ErrorHandler loggers if an exception is buffered
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents a fatal error when setting a new logger if the bootstrapping logger buffered an exception that does not extend
ErrorException.@nicolas-grekas The faulty behaviour was added by 8f24549, so this PR is against 3.2 and not 2.8.