301 status code must drop request method to GET. #21514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't remember the reasons why 301 was not included back then. 👍 for changing this in master. ping @symfony/deciders |
Tobion
reviewed
Feb 17, 2017
| @@ -507,6 +507,13 @@ public function testFollowRedirectWithPostMethod() | |||
| $this->assertArrayHasKey('X_TEST_FOO', $client->getRequest()->getServer(), '->followRedirect() keeps $_SERVER with POST method'); | |||
| $this->assertEquals($content, $client->getRequest()->getContent(), '->followRedirect() keeps content with POST method'); | |||
| $this->assertEquals('POST', $client->getRequest()->getMethod(), '->followRedirect() keeps request method'); | |||
|
|
|||
| foreach (array(301, 302, 303) as $code) { | |||
There was a problem hiding this comment.
This should be part of a new test. No need to put it here.
|
👍 |
|
👍 but this should be documented in the upgrade files |
|
@jlamur Can you take the comments into accounts? Moving the new tests to a new method and adding a note in the CHANGELOG/UPGRADE files? |
|
@fabpot I didn't had enough time to do it, but it will be done this weekend. |
|
@jlamur If you don't have time, I'm sure someone can take over and finish it. |
[RFC 7231 §6.4.2](https://tools.ietf.org/html/rfc7231#section-6.4.2) states that 301 HTTP Code should forward POST requests to the Location URI. But, it also states that: > For historical reasons, a user agent MAY change the request method from POST to GET for the subsequent request. This is the behavior implemented in almost all user agents. However the `BrowserKit` did forward the method to the subsequent request.
e16159b to
abda966
Compare
|
@fabpot Please let me know if I did something wrong while updating UPGRADE/CHANGELOG files. |
|
Thank you @jlamur. |
fabpot
added a commit
that referenced
this pull request
Mar 14, 2017
This PR was merged into the 3.3-dev branch. Discussion ---------- 301 status code must drop request method to GET. | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | BC breaks? | yes | Tests pass? | yes | Fixed tickets | #20924 | License | MIT [RFC 7231 §6.4.2](https://tools.ietf.org/html/rfc7231#section-6.4.2) states that 301 HTTP Code should forward POST requests to the Location URI. But, it also states that: > For historical reasons, a user agent MAY change the request method from POST to GET for the subsequent request. This is the behavior implemented in almost all user agents. However the `BrowserKit` did forward the method to the subsequent request. This PR make the `BrowserKit` change the request method from POST to GET when the response status code is 301. Commits ------- abda966 301 status code must drop request method to GET.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 7231 §6.4.2 states that 301 HTTP Code should forward POST requests to the Location URI.
But, it also states that:
This is the behavior implemented in almost all user agents.
However the
BrowserKitdid forward the method to the subsequent request.This PR make the
BrowserKitchange the request method from POST to GET when the response status code is 301.