[WebProfilerBundle] Readd Symfony version status in the toolbar #21584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Feb 11, 2017
There was a problem hiding this comment.
👍
@wouterj I'm sorry about this ... but as you said, it wasn't done on purpose. I wanted to remove the <a> to symfony.com because it's frustrating to click on that element and exit your application and go to symfony.com ... but the description about the version is definitely useful!
|
Thank you @wouterj. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 11, 2017
…olbar (wouterj) This PR was merged into the 2.8 branch. Discussion ---------- [WebProfilerBundle] Readd Symfony version status in the toolbar | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The Symfony version status (*"This Symfony version will no longer receive security fixes."* and the like) was no longer shown in the toolbar. This was removed in 9d89841 , but the commit description isn't that describing. I guess it's not done on purpose. I think having this information is crucial for this feature to work: A yellow version doesn't mean anything specific, unless I see "This Symfony will only receive security fixes". /cc @javiereguiluz Commits ------- d714c7e Readd Symfony version status in the toolbar
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Symfony version status ("This Symfony version will no longer receive security fixes." and the like) was no longer shown in the toolbar. This was removed in 9d89841 , but the commit description isn't that describing. I guess it's not done on purpose.
I think having this information is crucial for this feature to work: A yellow version doesn't mean anything specific, unless I see "This Symfony will only receive security fixes".
/cc @javiereguiluz