[DI][FrameworkBundle] ServiceLocator: Tests dumpers & update descriptors #21600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
Feb 14, 2017
| use Symfony\Component\DependencyInjection\ParameterBag\FrozenParameterBag; | ||
| use Symfony\Component\DependencyInjection\ServiceLocator; |
There was a problem hiding this comment.
All the order changes should be reverted
There was a problem hiding this comment.
Why? This is expected, I've updated the PhpDumper to do so (https://github.com/symfony/symfony/pull/21600/files#diff-f7b23d463cba27ac5e4cb677f2be7623R902).
I know it doesn't matter much, but this use directive was added in master, so I thought we could change this order to respect alphabetical one as soon as it's not released.
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Feb 14, 2017
…date descriptors (ogizanagi) This PR was merged into the 3.3-dev branch. Discussion ---------- [DI][FrameworkBundle] ServiceLocator: Tests dumpers & update descriptors | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | N/A | License | MIT | Doc PR | N/A This simply ensures the new feature is properly considered by the different dumpers, and updates the console descriptors to support the new `ServiceLocatorArgument`. I also added the number of elements in an array/iterator/service_locator argument when using the `TextDescriptor` in this PR. (fabbot is complaining about the new yaml tags support) Commits ------- aa9074d [DI][FrameworkBundle] ServiceLocator: Tests dumpers & update descriptors
stof
reviewed
Feb 14, 2017
| @@ -435,6 +436,12 @@ private function getArgumentNodes(array $arguments, \DOMDocument $dom) | |||
| foreach ($this->getArgumentNodes($argument->getValues(), $dom) as $childArgumentXML) { | |||
| $argumentXML->appendChild($childArgumentXML); | |||
| } | |||
| } elseif ($argument instanceof ServiceLocatorArgument) { | |||
| $argumentXML->setAttribute('type', 'service_locator'); | |||
There was a problem hiding this comment.
the XML format uses a dash, not a underscore. So we should do the same for the descriptor
fabpot
added a commit
that referenced
this pull request
Feb 16, 2017
…to use dashes (ogizanagi) This PR was merged into the 3.3-dev branch. Discussion ---------- [DI][FrameworkBundle] ServiceLocator: fix XmlDescriptor to use dashes | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21600 (comment) | License | MIT | Doc PR | N/A As reported by @stof, I should have used dashes, not underscores. My bad... Commits ------- 1417f11 [DI][FrameworkBundle] ServiceLocator: fix XML descriptor to use dashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply ensures the new feature is properly considered by the different dumpers, and updates the console descriptors to support the new
ServiceLocatorArgument.I also added the number of elements in an array/iterator/service_locator argument when using the
TextDescriptorin this PR.(fabbot is complaining about the new yaml tags support)