[FrameworkBundle] remove translation data collector when not usable #21637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Feb 16, 2017
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #17957 |
| License | MIT |
| Doc PR |
fabpot
reviewed
Feb 16, 2017
|
|
||
| $translatorClass = $container->findDefinition('translator')->getClass(); | ||
|
|
||
| if (!is_subclass_of($translatorClass, '\Symfony\Component\Translation\TranslatorBagInterface')) { |
There was a problem hiding this comment.
The leading \ can be removed I think.
36f54fa to
303bb73
Compare
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Feb 17, 2017
…ot usable (xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] remove translation data collector when not usable | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17957 | License | MIT | Doc PR | Commits ------- 303bb73 remove translation data collector when not usable
stof
reviewed
Feb 17, 2017
| return; | ||
| } | ||
|
|
||
| $translatorClass = $container->findDefinition('translator')->getClass(); |
There was a problem hiding this comment.
you need to resolve the value, as the class may use a parameter
fabpot
added a commit
that referenced
this pull request
Feb 20, 2017
…es (xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] resolve parameters in definition classes | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21637 (comment) | License | MIT | Doc PR | Commits ------- 37ce682 resolve parameters in definition classes
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Feb 20, 2017
…es (xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] resolve parameters in definition classes | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#21637 (comment) | License | MIT | Doc PR | Commits ------- 37ce682947 resolve parameters in definition classes
This was referenced Mar 6, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.