[VarDumper] Added a way to print or not comma separator and/or trailing comma #21653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a699b28 to
60c2a18
Compare
| @@ -107,6 +107,92 @@ class: "Symfony\Component\VarDumper\Tests\CliDumperTest" | |||
| ); | |||
| } | |||
|
|
|||
| public function testGetWithCommaFlag() | |||
| { | |||
| require __DIR__.'/Fixtures/dumb-var.php'; | |||
There was a problem hiding this comment.
I suggest to use a smaller fixture - one that contains a multiline string - and to test also the DUMP_TRAILING_COMMA flag
| @@ -274,7 +360,7 @@ public function testThrowingCaster() | |||
| %sTwig.php:2: { | |||
| : foo bar | |||
| : twig source | |||
| : | |||
| : | |||
There was a problem hiding this comment.
should be reverted (breaks tests)
dc30f7d to
431d57c
Compare
…ng comma Usecase: Be able to display a dump on one line. It's already used in the following projets: https://github.com/bobthecow/psysh/blob/master/src/Psy/VarDumper/Dumper.php#L93-L95
431d57c to
1ef0751
Compare
|
Thank you @lyrixx. |
fabpot
added a commit
that referenced
this pull request
Feb 20, 2017
…r and/or trailing comma (lyrixx) This PR was merged into the 3.3-dev branch. Discussion ---------- [VarDumper] Added a way to print or not comma separator and/or trailing comma | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - --- Usecase: Be able to display a dump on one line. It's already used in the following projets: https://github.com/bobthecow/psysh/blob/master/src/Psy/VarDumper/Dumper.php#L93-L95 Commits ------- 1ef0751 [VarDumper] Added a way to print or not comma separator and/or trailing comma
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usecase: Be able to display a dump on one line.
It's already used in the following projets: https://github.com/bobthecow/psysh/blob/master/src/Psy/VarDumper/Dumper.php#L93-L95