[DoctrineBridge] Fixed validating custom doctrine type columns #21656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
460fe7b to
c642345
Compare
|
Symfony 3.1 doesn't receive bug fixes any more. Can you rebase on the |
|
Ah sorry you are right. Will rebase it later today 😉 |
c642345 to
70d962c
Compare
70d962c to
ad59370
Compare
|
@xabbuh done 😉 |
xabbuh
reviewed
Feb 21, 2017
|
Thank you @dmaicher. |
fabpot
added a commit
that referenced
this pull request
Feb 21, 2017
…umns (dmaicher) This PR was merged into the 3.2 branch. Discussion ---------- [DoctrineBridge] Fixed validating custom doctrine type columns | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21619 | License | MIT | Doc PR | - This fixes #21619 by not assuming the invalid `$value` is a Doctrine entity if its an object Commits ------- ad59370 [DoctrineBridge] Fixed validating custom doctrine type columns
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #21619 by not assuming the invalid
$valueis a Doctrine entity if its an object