[DependencyInjection] add missing dumped private services list in a container frozen constructor. #21782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hhamon
commented
Feb 27, 2017
| Q | A |
|---|---|
| Branch? | 3.2 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | ~ |
|
Obviously there is a missing unit test for this and this is why we didn't spot the problem earlier. I'm adding some. |
943f9b6 to
fdd6d48
Compare
…ontainer frozen constructor.
fdd6d48 to
838d9ca
Compare
|
Thank you @hhamon. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 28, 2017
…list in a container frozen constructor. (hhamon) This PR was merged into the 3.2 branch. Discussion ---------- [DependencyInjection] add missing dumped private services list in a container frozen constructor. | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- 838d9ca [DependencyInjection] add missing dumped private services list in a container frozen constructor.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.