Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[2.7] Fix issues reported by static analyze #21800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2017

Conversation

romainneutron
Copy link
Contributor

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

This PR fixes invalid doc blocks (typo or missing use) and a sprintf issue

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stof
Copy link
Member

stof commented Feb 28, 2017

👍
Status: reviewed

@nicolas-grekas
Copy link
Member

Good catch, thanks @romainneutron.

@nicolas-grekas nicolas-grekas merged commit e473aa8 into symfony:2.7 Feb 28, 2017
nicolas-grekas added a commit that referenced this pull request Feb 28, 2017
This PR was merged into the 2.7 branch.

Discussion
----------

[2.7] Fix issues reported by static analyze

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

This PR fixes invalid doc blocks (typo or missing use) and a `sprintf` issue

Commits
-------

e473aa8 [2.7] Fix issues reported by static analyse
nicolas-grekas added a commit that referenced this pull request Feb 28, 2017
This PR was merged into the 2.8 branch.

Discussion
----------

[2.8] Fix issues reported by static analyse

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Followup #21800

Commits
-------

cb14bfd [2.8] Fix issues reported by static analyse
@romainneutron romainneutron deleted the 2.7-static-analyse branch February 28, 2017 15:15
This was referenced Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants