[3.2] Fix issues reported by static analyse #21802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainneutron
commented
Feb 28, 2017
| @@ -38,7 +38,7 @@ public function __construct($namespace = '', $defaultLifetime = 0, $version = nu | |||
| CacheItem::validateKey($version); | |||
|
|
|||
| if (!apcu_exists($version.'@'.$namespace)) { | |||
| $this->clear($namespace); | |||
There was a problem hiding this comment.
@nicolas-grekas The clear method has no argument; is it a bug?
There was a problem hiding this comment.
maybe it was expected to call doClear directly ?
romainneutron
commented
Feb 28, 2017
| $strict = true; | ||
| } | ||
|
|
||
| $arguments[$key] = new Reference($arg->getAttribute('id'), $invalidBehavior, $strict); |
There was a problem hiding this comment.
Reference has lost its third argument
51fabbe to
67e7b5a
Compare
67e7b5a to
a9ccacc
Compare
|
Thank you @romainneutron. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 28, 2017
This PR was merged into the 3.2 branch. Discussion ---------- [3.2] Fix issues reported by static analyse | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Follow-up #21801 Commits ------- a9ccacc [3.2] Fix issues reported by static analyse
nicolas-grekas
added a commit
that referenced
this pull request
Feb 28, 2017
…ron) This PR was merged into the 3.3-dev branch. Discussion ---------- [master] Fix issues reported by static analyse | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Follow-up #21802 Commits ------- 671694d [master] Fix issues reported by static analyse
|
@romainneutron which tool is used to do this analysis? |
HeahDude
reviewed
Mar 5, 2017
| @@ -296,7 +296,7 @@ protected function instantiateObject(array &$data, $class, array &$context, \Ref | |||
| if (__CLASS__ !== get_class($this)) { | |||
| $r = new \ReflectionMethod($this, __FUNCTION__); | |||
| if (__CLASS__ !== $r->getDeclaringClass()->getName()) { | |||
| @trigger_error(sprintf('Method %s() will have a 6th `$format = null` argument in version 4.0. Not defining it is deprecated since 3.2.', get_class($this), __FUNCTION__), E_USER_DEPRECATED); | |||
| @trigger_error(sprintf('Method %s::%s() will have a 6th `$format = null` argument in version 4.0. Not defining it is deprecated since 3.2.', get_class($this), __FUNCTION__), E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
__METHOD__ could have been used here as well (issue reported by organic analysis 
).
There was a problem hiding this comment.
@HeahDude organic analysis failure: get_class($this) !== __CLASS__ when $this is a child class of AbstractNormalizer (which it always is in this case ;) )
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up #21801