[FrameworkBundle][PropertyInfo] Move PropertyInfoPass to the PropertyInfo component #21806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
Feb 28, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
11 tasks
d146d6a to
558ed10
Compare
ogizanagi
approved these changes
Feb 28, 2017
GuilhemN
reviewed
Feb 28, 2017
| private $descriptionExtractorTag; | ||
| private $accessExtractorTag; | ||
|
|
||
| public function __construct($propertyInfoService = 'property_info', $listExtractorTag = 'property_info.list_extractor', $typeExtractorTag = 'property_info.type_extractor', $descriptionExtractorTag = 'property_info.description_extractor', $accessExtractorTag = 'property_info.access_extractor') |
There was a problem hiding this comment.
Is this kind of extension point really needed?
There was a problem hiding this comment.
Yes I think, we did it for each other (see #20250 (comment))
There was a problem hiding this comment.
Why not? It allows configuring multiple property info services in an application easily.
There was a problem hiding this comment.
It adds stuff to maintain and I'm not sure it's really useful, but if you think it is why not.
558ed10 to
7a7ff24
Compare
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Mar 1, 2017
…to the PropertyInfo component (chalasr) This PR was merged into the 3.3-dev branch. Discussion ---------- [FrameworkBundle][PropertyInfo] Move PropertyInfoPass to the PropertyInfo component | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 7a7ff24 Move PropertyInfoPass to the PropertyInfo component
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.