-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Adding use statement for InvalidArgumentException #21851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This should not cause a single BC break afaik |
You are correct. Technically this is not a BC break. But strictly speaking one could believe the intention was |
Should we apply this on the lowest supported branch where it goes ? |
I think so. But it is your call. That is why I wrote "master" |
I think this is more of an "improvement" than a feature or bugfix. Sadly there's no mention of this in the symfony docs/semver. However, I do think it falls under the following:
|
< 3.2 actually throws So for 2.7 you need to update the actual throws as well (https://github.com/symfony/symfony/blob/2.7/src/Symfony/Component/Translation/Translator.php#L463) Otherwise this could be 3.2 without any BC issue (it's a doc fix, at least for the current implementations ^^). |
Thank you @ro0NL. You are correct. So either merge in master or in 3.2 and up. |
Thank you @Nyholm. |
This PR was submitted for the master branch but it was merged into the 3.2 branch instead (closes #21851). Discussion ---------- Adding use statement for InvalidArgumentException | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This is a super minor bugfix. We should tell what InvalidArgumentException we throw. I consider this a bugfix and not a BC break because `Symfony\Component\Translation\Exception\InvalidArgumentException` has always been the intention. Commits ------- 187f65b Adding use statement for InvalidArgumentException
Thank you for merging |
This is a super minor bugfix. We should tell what InvalidArgumentException we throw. I consider this a bugfix and not a BC break because
Symfony\Component\Translation\Exception\InvalidArgumentException
has always been the intention.