[FrameworkBundle] Fix cleaning of test dirs #21972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
c957540 to
b2e7299
Compare
|
Failure on appveyor Status: needs work |
b2e7299 to
6a608df
Compare
|
Status: needs review |
6a608df to
4842c86
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Mar 14, 2017
…kas) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] Fix cleaning of test dirs | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I spent an hour or two today debugging a non existent issue that was related to a non removed temporary file. Let's cleanup properly now in the base WebTestCase. Commits ------- 4842c86 [FrameworkBundle] Fix cleaning of test dirs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent an hour or two today debugging a non existent issue that was related to a non removed temporary file.
Let's cleanup properly now in the base WebTestCase.