[HttpKernel] Fixed bug with purging of HTTPS URLs #22079
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
Nek-
reviewed
Mar 20, 2017
| $purgedHttp = $this->doPurge($http); | ||
| $purgedHttps = $this->doPurge($https); | ||
|
|
||
| return $purgedHttp || $purgedHttps; |
There was a problem hiding this comment.
Why changing this? The old version was better IMO as it doesn't execute the second purge if the one is properly done.
There was a problem hiding this comment.
That was the problem. Both versions of the cache entry – http AND https – should get purged. Before this change only the http version was purged.
There was a problem hiding this comment.
My bad. I was disturbed by the : change in the regex..
| $this->assertTrue($this->store->purge('http://example.com/foo')); | ||
| $this->assertEmpty($this->getStoreMetadata($requestHttp)); | ||
| $this->assertEmpty($this->getStoreMetadata($requestHttps)); | ||
| } |
There was a problem hiding this comment.
Am I wrong or the non-regression test is missing?
There was a problem hiding this comment.
What do you mean by non-regression test? I added two tests, one for each bug described in the initial issue comment.
Nek-
approved these changes
Mar 20, 2017
|
Thank you @ausi. |
fabpot
added a commit
that referenced
this pull request
Mar 21, 2017
This PR was squashed before being merged into the 2.7 branch (closes #22079). Discussion ---------- [HttpKernel] Fixed bug with purging of HTTPS URLs | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I found two bugs in `HttpCache\Store::purge()` with HTTPS URLs: 1. `->purge('https://example.com/')` only purges the `http` version not the `https` one. 2. If a cache entry exists for both `http` and `https`, only the `http` version gets purged, the `https` version stays in the cache. I think this issues were introduced with #21582. This pull request fixes both issues and adds tests for them. Commits ------- f509150 [HttpKernel] Fixed bug with purging of HTTPS URLs
This was referenced Apr 4, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found two bugs in
HttpCache\Store::purge()with HTTPS URLs:->purge('https://example.com/')only purges thehttpversion not thehttpsone.httpandhttps, only thehttpversion gets purged, thehttpsversion stays in the cache.I think this issues were introduced with #21582.
This pull request fixes both issues and adds tests for them.