HttpCache: New test for revalidating responses with an expired TTL #22099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
Mar 21, 2017
| sleep(15); // expire the cache | ||
|
|
||
| $this->setNextResponse(304, array(), '', function (Request $request, Response $response) use ($time) { | ||
| $this->assertEquals($time->format(DATE_RFC2822), $request->headers->get('IF_MODIFIED_SINCE')); |
There was a problem hiding this comment.
That does not work on PHP 5.3. You should create a$that var outside and pass it via use
There was a problem hiding this comment.
I always wonder whether you know this off by heart, or if the failing tests remind you of it?
There was a problem hiding this comment.
we all do the same mistake, so I don't need the test to fail to spot this kind of errors :)
There was a problem hiding this comment.
Fixed. Somehow I know this is will happen to me again. 🤔
|
Thank you @mpdude. |
fabpot
added a commit
that referenced
this pull request
Mar 21, 2017
…xpired TTL (mpdude) This PR was squashed before being merged into the 2.7 branch (closes #22099). Discussion ---------- HttpCache: New test for revalidating responses with an expired TTL | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | See #22035, in particular [this and the following comments](#22035 (comment)). Commits ------- 067ab52 HttpCache: New test for revalidating responses with an expired TTL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #22035, in particular this and the following comments.