Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[lock] Rename Quorum into Strategy #22114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2017

Conversation

jderusse
Copy link
Member

Q A
Branch? master
Bug fix? yes (not consistent naming)
New feature? no
BC breaks? yes (but version 3.4 not yet released)
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR

The term Quorum in Interface is confusing an not consistent with the Symfony project.
This PR switch to naming Strategy\StrategyInterface (like in adapter i Cache and Ldap component)

@fabpot
Copy link
Member

fabpot commented Mar 22, 2017

one small fabbot issue

@jderusse jderusse force-pushed the lock-strategy-interface branch from 604d916 to 1e9671b Compare March 22, 2017 22:05
@fabpot
Copy link
Member

fabpot commented Mar 22, 2017

Thank you @jderusse.

@fabpot fabpot merged commit 1e9671b into symfony:master Mar 22, 2017
fabpot added a commit that referenced this pull request Mar 22, 2017
This PR was merged into the 3.3-dev branch.

Discussion
----------

[lock] Rename Quorum into Strategy

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes (not consistent naming)
| New feature?  | no
| BC breaks?    | yes (but version 3.4 not yet released)
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        |

The term `Quorum` in Interface is confusing an not consistent with the Symfony project.
This PR switch to naming `Strategy\StrategyInterface` (like in adapter i `Cache` and `Ldap` component)

Commits
-------

1e9671b Rename Quorum into Strategy
@jderusse jderusse deleted the lock-strategy-interface branch March 23, 2017 20:12
@fabpot fabpot mentioned this pull request May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants