this logic does not seem to support callable values for $groupByOrder, while the interface allows it (and callables can be arrays, making things even worse).

I'd like to see this support both callables and predefined arrays. Something like this should work:

if ($groupByOrder) {
    if (is_callable($groupByOrder)) {
        // TODO
    } elseif (is_array($groupByOrder)) {
        // TODO
    }
}

@colinodell , thanks
Can you give me an example of callable groupByOrder you need ?
Which parameters you need in the function ?

The callable should be compatible with uksort - anything that takes two parameters, compares them, and returns an integer. Your code would then look something like this:

if ($groupByOrder) {
    if (is_callable($groupByOrder)) {
        uksort($otherViews, $groupByOrder);
    } elseif (is_array($groupByOrder)) {
        // TODO: Your existing code goes here
    }
}

I could then use any type of callable for the groupByOrder option:

• 'strnatcmp' - Sort them using a "natural order" algorithm via the strnatcmp() function
• [$this, 'sortGroups'] - Use the sortGroups() function on $this
• [Foo::class, 'sortGroups'] - Use the static sortGroups() function from the Foo class
• function ($a, $b) { return $b <=> $a; } - Use some anonymous function

@colinodell thanks, will do that soon

adding arguments in an interface is forbidden by our BC policy

this does not match the types supported by the implementation.

this does not support a PropertyPath, as you don't handle it

Does PropertyPath even make sense here?

The new value must be taken into account when building the cache key, otherwise a list could be reused while it was having a different order