[Console] Escape exception messages in renderException #22142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1791f32 to
cb13482
Compare
|
Tested it, and confirming this fixes the issue. Status: Reviewed |
|
build failure unrelated (I'm looking at it). |
|
@chalasr Looks like @nicolas-grekas is already on it #22177 |
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Mar 27, 2017
…alasr) This PR was merged into the 2.7 branch. Discussion ---------- [Console] Escape exception messages in renderException | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22021 | License | MIT | Doc PR | n/a Adding style on exception messages should be prevented, it leads to weird results. > Allowing formatting in them would be a nightmare, given that Symfony itself applies some formatting when rendering the exception. Commits ------- cb13482 [Console] Escape exception messages
|
It's a king a BC break isn't ? cf #9055 |
fabpot
added a commit
that referenced
this pull request
Mar 29, 2017
This PR was squashed before being merged into the 2.7 branch (closes #22188). Discussion ---------- [Console] Revised exception rendering | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> Continuation of #22142, as escaping can break too i just realized. Before  After  cc @chalasr Commits ------- 17f1f07 [Console] Revised exception rendering
This was referenced Apr 4, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding style on exception messages should be prevented, it leads to weird results.