[WebProfilerBundle] Normalize whitespace in exceptions passed in headers #22154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should be applied to 2.7 |
If an exception was thrown with line separators in its message the WebProfiler would cause an exception by passing it through unsanitized into the X-Debug-Error HTTP header. This commit fixes that by replacing all whitespace sequences with a single space in the header.
|
Rebased on 2.7 |
|
Thank you @curry684. |
fabpot
added a commit
that referenced
this pull request
Mar 29, 2017
…sed in headers (curry684) This PR was merged into the 2.7 branch. Discussion ---------- [WebProfilerBundle] Normalize whitespace in exceptions passed in headers | Q | A | ------------- | --- | Branch? | 2.7 upwards | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22072 | License | MIT If an exception was thrown with line separators in its message the WebProfiler would cause an exception by passing it through unsanitized into the X-Debug-Error HTTP header. This commit fixes that by replacing all whitespace sequences with a single space in the header. Commits ------- d646790 [WebProfilerBundle] Normalize whitespace in exceptions passed in headers
This was referenced Apr 4, 2017
Merged
Merged
Merged
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
…ons passed in headers (curry684) This PR was merged into the 2.7 branch. Discussion ---------- [WebProfilerBundle] Normalize whitespace in exceptions passed in headers | Q | A | ------------- | --- | Branch? | 2.7 upwards | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#22072 | License | MIT If an exception was thrown with line separators in its message the WebProfiler would cause an exception by passing it through unsanitized into the X-Debug-Error HTTP header. This commit fixes that by replacing all whitespace sequences with a single space in the header. Commits ------- d646790 [WebProfilerBundle] Normalize whitespace in exceptions passed in headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an exception was thrown with line separators in its message the WebProfiler would cause an exception by passing it through unsanitized into the X-Debug-Error HTTP header. This commit fixes that by replacing all whitespace sequences with a single space in the header.