Fix port usage in server:status command #22172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No idea what the build failure on PHP 7 is about - Edit: travis gives build errors, not sure they are related to the PR though. Couldn't reproduce them on PHP 7 locally. |
|
Thank you @alcaeus. |
fabpot
added a commit
that referenced
this pull request
Mar 27, 2017
This PR was merged into the 2.7 branch. Discussion ---------- Fix port usage in server:status command | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT This fixes a bug where running `console server:status -p 8001` won't work because the port is already contained in the default value for `address`. Commits ------- dbcfa5c Remove port from default host in server:status command
This was referenced Apr 4, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where running
console server:status -p 8001won't work because the port is already contained in the default value foraddress.