[Workflow] Added 'workflow_marked_places' twig function #22180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
659bd29 to
4a2335a
Compare
HeahDude
reviewed
Mar 27, 2017
| * Returns true if the transition is enabled. | ||
| * | ||
| * @param object $subject A subject | ||
| * @param string $transitionName A transition |
There was a problem hiding this comment.
This parameter name mismatches the one of the signature and same below.
| * Returns true if the transition is enabled. | ||
| * | ||
| * @param object $subject A subject | ||
| * @param string $transitionName A transition |
There was a problem hiding this comment.
This one should even be added in 3.2.
| @@ -33,22 +33,69 @@ public function getFunctions() | |||
| new \Twig_SimpleFunction('workflow_can', array($this, 'canTransition')), | |||
| new \Twig_SimpleFunction('workflow_transitions', array($this, 'getEnabledTransitions')), | |||
| new \Twig_SimpleFunction('workflow_has_marked_place', array($this, 'hasMarkedPlace')), | |||
| new \Twig_SimpleFunction('workflow_places', array($this, 'getMarkedPlaces')), | |||
There was a problem hiding this comment.
It should be workflow_marked_places to avoid confusion as you stated in the previous PR.
There was a problem hiding this comment.
I did not choose workflow_marked_places in order to be consistant with workflow_transitions.
But you are right, I updated the PR.
Thanks.
|
Comments addressed. |
HeahDude
reviewed
Mar 29, 2017
| * Returns true if the place is marked. | ||
| * | ||
| * @param object $subject A subject | ||
| * @param string $transitionName A transition |
HeahDude
reviewed
Mar 29, 2017
| } | ||
|
|
||
| /** | ||
| * Returns all places. |
There was a problem hiding this comment.
Hmmm, maybe this should be more accurate?
When someone uses a custom MarkingStore, the value in the $subject::marking can be really different from the value inside Marking::getPlaces(). This occurs, for example, when the value stored in the subject is a bit mask. So it's always safer to get the places names from the marking, and so with this new function.
|
Failures are not related. |
|
👍 |
lyrixx
added a commit
that referenced
this pull request
Apr 3, 2017
…n (lyrixx)
This PR was merged into the 3.3-dev branch.
Discussion
----------
[Workflow] Added 'workflow_marked_places' twig function
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
---
When someone uses a custom MarkingStore, the value in the
$subject::marking can be really different from the value inside
Marking::getPlaces(). This occurs, for example, when the value stored in
the subject is a bit mask.
So it's always safer to get the places names from the marking, and so
with this new function.
---
usage:
```twig
{{ workflow_marked_places(post)|join(',') }}
```
Commits
-------
ead6f14 [Workflow] Added 'workflow_marked_places' twig function
chalasr
pushed a commit
to chalasr/symfony
that referenced
this pull request
Apr 5, 2017
…function (lyrixx)
This PR was merged into the 3.3-dev branch.
Discussion
----------
[Workflow] Added 'workflow_marked_places' twig function
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
---
When someone uses a custom MarkingStore, the value in the
$subject::marking can be really different from the value inside
Marking::getPlaces(). This occurs, for example, when the value stored in
the subject is a bit mask.
So it's always safer to get the places names from the marking, and so
with this new function.
---
usage:
```twig
{{ workflow_marked_places(post)|join(',') }}
```
Commits
-------
ead6f14 [Workflow] Added 'workflow_marked_places' twig function
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When someone uses a custom MarkingStore, the value in the
$subject::marking can be really different from the value inside
Marking::getPlaces(). This occurs, for example, when the value stored in
the subject is a bit mask.
So it's always safer to get the places names from the marking, and so
with this new function.
usage:
{{ workflow_marked_places(post)|join(',') }}