[Console] Fix table cell styling #22217

ro0NL · 2017-03-29T14:18:02Z

Q	A
Branch?	2.7
Bug fix?	yes
New feature?	tiny one
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#...
License	MIT
Doc PR	symfony/symfony-docs#...

Fixes an issue with newlines and table cells. Remembered this little trick from @chalasr as we had it before with style blocks i believe..

$table = new Table($output);
$table->setRows(array(
    array(new TableCell('<error>Dont break'."\n".'here</error>', array('colspan' => 2))),
    new TableSeparator(),
    array('foo', new TableCell('<error>Dont break'."\n".'here</error>', array('rowspan' => 2))),
    array('bar'),
));
$table->render();

Before

After

chalasr · 2017-03-29T14:34:39Z

👍 nice catch

Status: reviewed

ro0NL · 2017-03-29T15:50:41Z

applies to rowspan as well.. looking at it.

ro0NL · 2017-03-29T16:12:07Z

too bad.. the trick doesnt seem to work in that case

ie this one still fails;

$table = new Table($output);
$table->setRow(0, array(new TableCell('f<error>o'."\n".'o</error>o', array('rowspan' => 2)), 'a'));
$table->setRow(1, array('b'));
$table->render();

edit: the same trick does work at first sight.. but breaks tests (e.g. Cell with rowspan and colspan contains new line break).

edit2: all good now :)

chalasr · 2017-03-29T17:38:16Z

Status: needs review
then :)

ro0NL · 2017-03-29T17:40:16Z

Agree. Had to add a tiny new feature as well.

chalasr

Looks good to me

stof

👍

stof · 2017-03-30T10:13:30Z

Status: Reviewed

fabpot · 2017-03-31T14:33:17Z

Thank you @ro0NL.

@chalasr

This PR was merged into the 2.7 branch. Discussion ---------- [Console] Fix table cell styling | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | tiny one | BC breaks? | no | Deprecations? | no  | Tests pass? | yes | Fixed tickets | #...  | License | MIT | Doc PR | symfony/symfony-docs#...  Fixes an issue with newlines and table cells. Remembered this little trick from @chalasr as we had it before with style blocks i believe.. ```php $table = new Table($output); $table->setRows(array( array(new TableCell('<error>Dont break'."\n".'here</error>', array('colspan' => 2))), new TableSeparator(), array('foo', new TableCell('<error>Dont break'."\n".'here</error>', array('rowspan' => 2))), array('bar'), )); $table->render(); ``` Before ![image](https://cloud.githubusercontent.com/assets/1047696/24467857/74dacc9e-14b6-11e7-8f62-3831508ac949.png) After ![image](https://cloud.githubusercontent.com/assets/1047696/24467923/bb578f0e-14b6-11e7-85ed-039cd73b81a0.png) Commits ------- 53ecf83 [Console] Fix table cell styling

chalasr · 2017-04-04T08:59:32Z

@ro0NL It looks like merging this up to master broken tests with high deps, see e.g. https://travis-ci.org/symfony/symfony/jobs/218357015#L2631. Maybe the merge went wrong?

ro0NL · 2017-04-04T09:08:47Z

@chalasr I think this PR went fine.. looking at your travis result it looks like #22188 is causing the failure...

Not sure what's going on.. ill have a look asap.

chalasr · 2017-04-04T13:21:29Z

I do think the descriptors failures are related to this one though :/ (frameworkbundle, see https://ci.appveyor.com/project/fabpot/symfony/build/1.0.20617#L598). Quite hard to fix for me right now

ro0NL · 2017-04-04T13:28:00Z

👍 gonna have a look at it asap. For now im clueless about the failure...

-| Options      | compiler_class: Symfony\Component\Routing\RouteCompiler |
-|              | opt1: val1                                              |
-|              | opt2: val2                                              |
+| Options      | compiler_class: Symfony\Component\Routing\RouteCompiler |
+|              | opt1: val1                                              |
+|              | opt2: val2                                              |

Seems whitespace related.. not sure :)

chalasr · 2017-04-04T13:29:41Z

Break-line and/or whitespaces, pretty sure :)
Thank you for looking into!

Broken from 2.8 btw

ro0NL · 2017-04-04T14:27:07Z

OK.. figured it out. The thing is we're replacing "\n" with "<fg=default;bg=default>\n</>".

In above example (the route options) contain 2 new lines.. meaning with this replacement the fixture changes as well. Visually you dont see it :)

Will prepare a PR for 2.8 👍

chalasr · 2017-04-04T14:28:14Z

You rock!

ro0NL · 2017-04-04T14:33:56Z

See #22278

@chalasr

This PR was squashed before being merged into the 3.2 branch (closes #22270). Discussion ---------- [Console] Fix render exception test | Q | A | ------------- | --- | Branch? | 3.2 and up | Bug fix? | yes (regression from #22188 in master) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22217 (comment) | License | MIT | Doc PR | symfony/symfony-docs#...  As pointed out by @chalasr tests are mysteriously broken.. not sure what i missed but this is apparently needed now.. cc @fabpot Commits ------- 6b71722 [Console] Fix render exception test

@fabpot

…ro0NL) This PR was squashed before being merged into the 2.8 branch (closes #22278). Discussion ---------- [FrameworkBundle] Update console fixtures after #22217 | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes (regression from #22217) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22217 (comment) | License | MIT | Doc PR | symfony/symfony-docs#...  cc @fabpot Sorry for the inconvenience :) Commits ------- 6e1cee6 [FrameworkBundle] Update console fixtures after #22217

@fabpot

…ro0NL) This PR was squashed before being merged into the 2.8 branch (closes #22278). Discussion ---------- [FrameworkBundle] Update console fixtures after #22217 | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes (regression from #22217) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#22217 (comment) | License | MIT | Doc PR | symfony/symfony-docs#...  cc @fabpot Sorry for the inconvenience :) Commits ------- 6e1cee6 [FrameworkBundle] Update console fixtures after #22217

* 2.8: [FrameworkBundle] Update console fixtures after #22217

* 3.2: [FrameworkBundle] Update console fixtures after #22217 Allow Upper Case property names fix some risky tests bumped Symfony version to 2.7.27 updated VERSION for 2.7.26 update CONTRIBUTORS for 2.7.26 updated CHANGELOG for 2.7.26

carsonbot added the Status: Reviewed label Mar 29, 2017

carsonbot added Status: Needs Review and removed Status: Reviewed labels Mar 29, 2017

chalasr approved these changes Mar 29, 2017

View reviewed changes

[Console] Fix table cell styling

53ecf83

stof approved these changes Mar 30, 2017

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Mar 30, 2017

fabpot merged commit 53ecf83 into symfony:2.7 Mar 31, 2017

ro0NL deleted the console/style branch March 31, 2017 14:40

fabpot mentioned this pull request Apr 4, 2017

Release v2.7.26 #22263

Merged

ro0NL mentioned this pull request Apr 4, 2017

[Console] Fix render exception test #22270

Closed

ro0NL mentioned this pull request Apr 4, 2017

[FrameworkBundle] Update console fixtures after #22217 #22278

Closed

chalasr pushed a commit to chalasr/symfony that referenced this pull request Apr 4, 2017

[FrameworkBundle] Update console fixtures after symfony#22217

7490f38

nicolas-grekas pushed a commit that referenced this pull request Apr 4, 2017

[FrameworkBundle] Update console fixtures after #22217

6e1cee6

nicolas-grekas added a commit that referenced this pull request Apr 4, 2017

Merge branch '2.8' into 3.2

aa46df1

* 2.8: [FrameworkBundle] Update console fixtures after #22217

This was referenced Apr 5, 2017

Release v2.8.19 #22284

Merged

Release v3.2.7 #22293

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Console] Fix table cell styling #22217

[Console] Fix table cell styling #22217

ro0NL commented Mar 29, 2017 •

edited

Loading

chalasr commented Mar 29, 2017

ro0NL commented Mar 29, 2017

ro0NL commented Mar 29, 2017 •

edited

Loading

chalasr commented Mar 29, 2017

ro0NL commented Mar 29, 2017

chalasr left a comment

stof left a comment

stof commented Mar 30, 2017

fabpot commented Mar 31, 2017

chalasr commented Apr 4, 2017

ro0NL commented Apr 4, 2017

chalasr commented Apr 4, 2017

ro0NL commented Apr 4, 2017 •

edited

Loading

chalasr commented Apr 4, 2017 •

edited

Loading

ro0NL commented Apr 4, 2017

chalasr commented Apr 4, 2017

ro0NL commented Apr 4, 2017

[Console] Fix table cell styling #22217

[Console] Fix table cell styling #22217

Conversation

ro0NL commented Mar 29, 2017 • edited Loading

chalasr commented Mar 29, 2017

ro0NL commented Mar 29, 2017

ro0NL commented Mar 29, 2017 • edited Loading

chalasr commented Mar 29, 2017

ro0NL commented Mar 29, 2017

chalasr left a comment

Choose a reason for hiding this comment

stof left a comment

Choose a reason for hiding this comment

stof commented Mar 30, 2017

fabpot commented Mar 31, 2017

chalasr commented Apr 4, 2017

ro0NL commented Apr 4, 2017

chalasr commented Apr 4, 2017

ro0NL commented Apr 4, 2017 • edited Loading

chalasr commented Apr 4, 2017 • edited Loading

ro0NL commented Apr 4, 2017

chalasr commented Apr 4, 2017

ro0NL commented Apr 4, 2017

ro0NL commented Mar 29, 2017 •

edited

Loading

ro0NL commented Mar 29, 2017 •

edited

Loading

ro0NL commented Apr 4, 2017 •

edited

Loading

chalasr commented Apr 4, 2017 •

edited

Loading