[ExpressionLanguage] Provide the expression in syntax errors #22229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fabbot failure - but shouldn't this be done on master instead? a new public method looks like a new feature to me - the DX "fix" looks like DX "improvement" to me. |
|
well, the new method is quite internal (I should tag it as |
|
Regarding the target, the original PR was on 2.7. But deciding between 2.7 and master can be discussed. The current exceptions when using a wrong expression in a DI configuration are totally impossible to debug (the error message does not contain the expression, and the stack trace does not contain the config file containing the expression as the expression is parsed only later when dumping the compiled container). So I would still be in favor of adding it in 2.7 |
776642c to
7cd7441
Compare
|
Thank you @stof. |
fabpot
added a commit
that referenced
this pull request
Apr 3, 2017
…rs (k0pernikus, stof) This PR was merged into the 2.7 branch. Discussion ---------- [ExpressionLanguage] Provide the expression in syntax errors | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19445 | License | MIT | Doc PR | n/a This finishes the PR #19449. Commits ------- 7cd7441 Complete the injection of the expression in all syntax errors dc55db2 add expression text to SyntaxError
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes the PR #19449.