[DI] Fix fatal error at ContainerBuilder::compile() if config is not installed #22240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linaori
reviewed
Apr 2, 2017
| { | ||
| parent::__construct($parameterBag); | ||
|
|
||
| $this->trackResources = interface_exists('Symfony\Component\Config\Resource\ResourceInterface'); |
There was a problem hiding this comment.
Could this be simply interface_exists(ResourceInterface::class);? The class is already imported anyway
There was a problem hiding this comment.
This targets 2.7 which supports PHP 5.3+ :/
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 3, 2017
…fig is not installed (chalasr) This PR was merged into the 2.7 branch. Discussion ---------- [DI] Fix fatal error at ContainerBuilder::compile() if config is not installed | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Using the DI component independently, running the following code: ```php (new ContainerBuilder())->compile(); ``` gives > Fatal error: Uncaught Error: Class 'Symfony\Component\Config\Resource\FileResource' not found Considering that using the container without ever compiling it doesn't really make sense, I think this currently makes the config component an hard requirement. I propose to make it softer as a bug fix, enabling resource tracking by default only if the config component is installed. Commits ------- 75d5cb1 Disable resource tracking if the config component is missing
This was referenced Apr 4, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the DI component independently, running the following code:
gives
Considering that using the container without ever compiling it doesn't really make sense, I think this currently makes the config component an hard requirement. I propose to make it softer as a bug fix, enabling resource tracking by default only if the config component is installed.