[PropertyInfo] Support nullable array or collection #22251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
requested changes
Apr 3, 2017
| @@ -242,7 +242,7 @@ private function getDocBlockFromProperty($class, $property) | |||
| * @param string $ucFirstProperty | |||
| * @param int $type | |||
| * | |||
| * @return DocBlock|null | |||
| * @return array|null | |||
There was a problem hiding this comment.
This change should be reverted (this method returns an instance of DocBlock, not an array).
There was a problem hiding this comment.
I think you forgot to expand the code :)
Look at the line 287
dunglas
approved these changes
Apr 3, 2017
xabbuh
approved these changes
Apr 3, 2017
|
Thanks for fixing this bug @4rthem. |
dunglas
added a commit
that referenced
this pull request
Apr 3, 2017
This PR was merged into the 2.8 branch. Discussion ---------- [PropertyInfo] Support nullable array or collection | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22248 | License | MIT | Doc PR | `@var array|null` was always considered as not nullable in the `PhpDocExtractor`. Commits ------- 74ee588 support nullable array or collection
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@var array|nullwas always considered as not nullable in thePhpDocExtractor.