[DI/Yaml] Remove @experimental flag from "instanceof" and "prototype"
#22286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Apr 5, 2017
src/Symfony/Component/Yaml/Yaml.php
Outdated
|
|
||
| /** | ||
| * @experimental in version 3.3 | ||
| */ | ||
| const PARSE_CUSTOM_TAGS = 512; |
There was a problem hiding this comment.
I think I would then move this flag between PARSE_CONSTANT and DUMP_EMPTY_ARRAY_AS_SEQUENCE.
There was a problem hiding this comment.
moved up in the list
|
I also think we need to commit to these features and follow normal deprecation policies. 👍 |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Apr 5, 2017
…" and "prototype" (nicolas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [DI/Yaml] Remove `@experimental` flag from "instanceof" and "prototype" | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - We don't need this flag on these features: the implementation is stable, and regular deprecations should be the way to go in the event where we decide to remove this later on. That would leave only one single `@experimental` feature in 3.3: `CacheItem::getPreviousTags()`, which looks legitimate to me (since this method is aiming at interop). Commits ------- e8723df [DI/Yaml] Remove `@experimental` flag from "instanceof" and "prototype"
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need this flag on these features: the implementation is stable, and regular deprecations should be the way to go in the event where we decide to remove this later on.
That would leave only one single
@experimentalfeature in 3.3:CacheItem::getPreviousTags(), which looks legitimate to me (since this method is aiming at interop).