Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Console] Inherit phpdoc from OutputFormatterInterface #22342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2017
Merged

[Console] Inherit phpdoc from OutputFormatterInterface #22342

merged 1 commit into from
Apr 10, 2017

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Apr 7, 2017

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #22225 (comment)
License MIT
Doc PR symfony/symfony-docs#...

*
* @return OutputFormatterStyleInterface
*
* @throws \InvalidArgumentException When style isn't defined
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me know if this need to be added to the interface (see also #22231).

Copy link
Member

@chalasr chalasr Apr 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say it should be. unrelated but this should use the console domain exception instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally i never add logic ones to the interface.. only concrete runtime scenarios that all implementations must adhere to (SomethingIsWrongException). But this is a thin line in PHP so i dont mind, hence i asked :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's see what others think then :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to clarify.. i always follow; logic=programmers fault, runtime=program fault

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given the actual implementation is a program fault.. i think im gonna add it. I would have used StyleNotFoundException extends \RuntimeException. But that's semantics.. who cares :P

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Apr 10, 2017
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fabpot
Copy link
Member

fabpot commented Apr 10, 2017

Thank you @ro0NL.

@fabpot fabpot merged commit ff3cb9c into symfony:2.7 Apr 10, 2017
fabpot added a commit that referenced this pull request Apr 10, 2017
…ro0NL)

This PR was merged into the 2.7 branch.

Discussion
----------

[Console] Inherit phpdoc from OutputFormatterInterface

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22225 (comment)
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

Commits
-------

ff3cb9c [Console] Inherit phpdoc from OutputFormatterInterface
@ro0NL ro0NL deleted the console/move-phpdoc branch April 10, 2017 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants