[Validator] Add canonicalize option for Locale validator
#22353
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canonicalize option for Locale validatorcanonicalize option for Locale validator
e769c77 to
ac83b88
Compare
Koc
reviewed
Aug 2, 2017
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function __construct($options = null) |
There was a problem hiding this comment.
Do we need constructor with custom code here?
Koc
reviewed
Aug 2, 2017
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function getDefaultOption() |
There was a problem hiding this comment.
Does this method relates to validator class?
|
Moving to 4.1. Rebase on master might be needed, where PHP 7.1 features can be used btw. |
ac83b88 to
8babc2c
Compare
|
@Koc, sorry for the delay. Your comments were already addressed. |
8babc2c to
b07d5a7
Compare
fabpot
approved these changes
Feb 7, 2018
|
Thank you @phansys. |
|
Thinking about this feature (after merging it), would it make sense to always canolicalize the value instead of making it configurable? |
|
IMO, it would be really useful to allow this validator to always canonicalize the input data, but I think this behavior will break the current "strictness" and thus, that change should be considered a BC break. |
|
@phansys Can you work on a PR to generate a deprecation message when canoicalize is |
|
Sure @fabpot, I'll be working on it 👍 |
symfony-splitter
pushed a commit
to symfony/validator
that referenced
this pull request
Feb 20, 2018
…raint without setting "canonicalize" option to `true` (phansys) This PR was merged into the 4.1-dev branch. Discussion ---------- [Validator] Deprecate use of `Locale` validation constraint without setting "canonicalize" option to `true` |Q |A | |--- |--- | |Branch |master | |Bug fix? |no | |New feature? |no | |BC breaks? |no | |Deprecations?|yes | |Tests pass? |yes | |Fixed tickets|#22353 | |License |MIT | |Doc PR |symfony/symfony-docs#9248| See symfony/symfony#22353 (comment). Commits ------- 1572540a3a Deprecate use of `Locale` validation constraint without setting "canonicalize" option to `true`
fabpot
added a commit
that referenced
this pull request
Feb 20, 2018
…raint without setting "canonicalize" option to `true` (phansys) This PR was merged into the 4.1-dev branch. Discussion ---------- [Validator] Deprecate use of `Locale` validation constraint without setting "canonicalize" option to `true` |Q |A | |--- |--- | |Branch |master | |Bug fix? |no | |New feature? |no | |BC breaks? |no | |Deprecations?|yes | |Tests pass? |yes | |Fixed tickets|#22353 | |License |MIT | |Doc PR |symfony/symfony-docs#9248| See #22353 (comment). Commits ------- 1572540 Deprecate use of `Locale` validation constraint without setting "canonicalize" option to `true`
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Feb 23, 2018
…` validation constraint (phansys, javiereguiluz) This PR was merged into the master branch. Discussion ---------- [Validator] Add docs for "canonicalize" option at `Locale` validation constraint Related to symfony/symfony#22353, symfony/symfony#26075. Closes #7660. Commits ------- 14f10bc Final changes 4c28e1f Minor changes 0cc4ee8 Add docs for "canonicalize" option at `Locale` validation constraint
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow non canonicalized locales ('fr-FR' by instance) to pass the validation.
Relates to symfony/symfony-docs#7660.