[DI] Throw useful exception on bad XML argument tags #22527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4bd1723 to
bbfcad4
Compare
|
Needs #22529 to be green. |
GuilhemN
reviewed
Apr 26, 2017
| @@ -474,6 +476,9 @@ private function getArgumentsAsPhp(\DOMElement $node, $name, $lowercase = true, | |||
|
|
|||
| switch ($arg->getAttribute('type')) { | |||
| case 'service': | |||
| if (!$arg->getAttribute('id')) { | |||
There was a problem hiding this comment.
An empty attribute is also invalid, so better as is IMHO
stof
requested changes
Apr 26, 2017
| @@ -484,17 +489,23 @@ private function getArgumentsAsPhp(\DOMElement $node, $name, $lowercase = true, | |||
| $arguments[$key] = new Expression($arg->nodeValue); | |||
| break; | |||
| case 'closure-proxy': | |||
| if (!$arg->getAttribute('id')) { | |||
| throw new InvalidArgumentException(sprintf('Tag "<%s>" with type="service" is missing an "id" attribute in "%s".', $name, $file)); | |||
| throw new InvalidArgumentException(sprintf('Tag "<%s>" with type="service" is missing an "id" attribute in "%s".', $name, $file)); | ||
| } | ||
| if (!$arg->getAttribute('method')) { | ||
| throw new InvalidArgumentException(sprintf('Tag "<%s>" with type="service" is missing a "method" attribute in "%s".', $name, $file)); |
ae21520 to
cdc24ba
Compare
|
rebased |
GuilhemN
approved these changes
Apr 26, 2017
| @@ -474,6 +476,9 @@ private function getArgumentsAsPhp(\DOMElement $node, $name, $lowercase = true, | |||
|
|
|||
| switch ($arg->getAttribute('type')) { | |||
| case 'service': | |||
| if (!$arg->getAttribute('id')) { | |||
fabpot
reviewed
Apr 29, 2017
| @@ -474,6 +476,9 @@ private function getArgumentsAsPhp(\DOMElement $node, $name, $lowercase = true, | |||
|
|
|||
| switch ($arg->getAttribute('type')) { | |||
| case 'service': | |||
| if (!$arg->getAttribute('id')) { | |||
| throw new InvalidArgumentException(sprintf('Tag "<%s>" with type="service" is missing an "id" attribute in "%s".', $name, $file)); | |||
cdc24ba to
91828ec
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Apr 29, 2017
…nicolas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] Throw useful exception on bad XML argument tags | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22525 | License | MIT | Doc PR | - I still think that the feature request in #22525 would make things better. But at least, let's make thing fail loudly, instead of silently today, with the associated usual wtfs :) Commits ------- 91828ec [DI] Throw useful exception on bad XML argument tags
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still think that the feature request in #22525 would make things better.
But at least, let's make thing fail loudly, instead of silently today, with the associated usual wtfs :)